GIVCAMP-294 | Basic Hero overlay options and image optimization #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for giving-campaign ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yvonnetangsu
commented
Mar 6, 2024
| @@ -2,7 +2,7 @@ import { cnb } from 'cnbuilder'; | |||
|
|
|||
| export const root = 'relative overflow-hidden'; | |||
| export const bgImage = 'absolute top-0 left-0 w-full h-full object-cover'; | |||
| export const overlay = (hasBgGradient?: boolean) => cnb('absolute top-0 left-0 w-full h-full z-10', hasBgGradient ? 'bg-gradient-to-t' : ''); | |||
| export const overlay = (hasBgGradient?: boolean) => cnb('absolute top-0 left-0 w-full h-full z-10', hasBgGradient ? 'bg-gradient-to-b' : ''); | |||
There was a problem hiding this comment.
Previously I had the gradient direction going from bottom to top to take advantage of not having to write to-transparent TW class (no need to write this if fading to transparent). However, after testing real example pages, I found that we rarely would start with a transparent color at the top anyway so no need for me to do this reverse gradient trick.
|
Merging this one in @sherakama ! I've looked at the preview build and things should be fine. |
Merged
yvonnetangsu
added a commit
that referenced
this pull request
Mar 6, 2024
* dev: 1.2.2 GIVCAMP-294 | Basic Hero overlay options and image optimization (#243) HSTS set max-age to 31536000 (#242) 1.2.1 Icon animation (#240) GIVCAMP-304 | Add CTA region to Section and Homepage Theme/Story Section (#239)
yvonnetangsu
added a commit
that referenced
this pull request
Apr 2, 2024
* dev: (34 commits) GIVCAMP-292 GIVCAMP-305 | Horizontal Initiative card and image aspect ratio options (#256) 1.3.3 Update robots to use different URL for sitemap path (#254) 1.3.2 GIVCAMP-307 | Stacked story hero variant (#251) 1.3.1 GIVCAMP-297 GIVCAMP-312 | Section background options + add light overlay options (#248) Bump follow-redirects from 1.15.4 to 1.15.6 (#249) 1.3.0 GIVCAMP-289: Inline External Script Loading. (#246) GIVCAMP-88 | data card (#245) 1.2.2 GIVCAMP-294 | Basic Hero overlay options and image optimization (#243) HSTS set max-age to 31536000 (#242) 1.2.1 Icon animation (#240) GIVCAMP-304 | Add CTA region to Section and Homepage Theme/Story Section (#239) 1.2.0 GIVCAMP-293 | Moment poster (#236) NoJira: Remove Editor Token (#237) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Review By (Date)
Criticality
Review Tasks
Setup tasks and/or behavior to test
https://deploy-preview-243--giving-campaign.netlify.app/newsletter/sign-up
https://deploy-preview-243--giving-campaign.netlify.app/404
Associated Issues and/or People